Adjust migration to support mysql 5.7

db/migrations/20240808118000_drop_unique_constraint_quota_definitions_name_key.rb

@@ -1,30 +1,36 @@
 Sequel.migration do
   up do
-    if self.class.name.match?(/mysql/i)
-      alter_table :quota_definitions do
-        drop_constraint :name, if_exists: true
+    if database_type == :mysql
+      if indexes(:quota_definitions).include?(:name)
+        alter_table :quota_definitions do
+          # rubocop:disable Sequel/ConcurrentIndex
+          drop_index :name, name: :name
+          # rubocop:enable Sequel/ConcurrentIndex
+        end
       end
-    elsif self.class.name.match?(/postgres/i)
-      alter_table :quota_definitions do
-        drop_constraint :quota_definitions_name_key, if_exists: true
+    elsif database_type == :postgres
+      if indexes(:quota_definitions).include?(:quota_definitions_name_key)
+        alter_table :quota_definitions do
+          drop_constraint :quota_definitions_name_key
+        end
       end
     end
   end
 
   down do
-    if self.class.name.match?(/mysql/i)
-      # mysql 5 is not so smart as mysql 8, prevent Mysql2::Error: Duplicate key name 'name'
-      alter_table :quota_definitions do
-        # rubocop:disable Sequel/ConcurrentIndex
-        drop_index :name, name: :name if @db.indexes(:quota_definitions).include?(:name)
-        # rubocop:enable Sequel/ConcurrentIndex
+    if database_type == :mysql
+      unless indexes(:quota_definitions).include?(:name)
+        alter_table :quota_definitions do
+          # rubocop:disable Sequel/ConcurrentIndex
+          add_index :name, name: :name, unique: true
+          # rubocop:enable Sequel/ConcurrentIndex
+        end
       end
-      alter_table :quota_definitions do
-        add_unique_constraint :name, name: :name, if_not_exists: true
-      end
-    elsif self.class.name.match?(/postgres/i)
-      alter_table :quota_definitions do
-        add_unique_constraint :name, name: :quota_definitions_name_key, if_not_exists: true
+    elsif database_type == :postgres
+      unless indexes(:quota_definitions).include?(:quota_definitions_name_key)
+        alter_table :quota_definitions do
+          add_unique_constraint :name, name: :quota_definitions_name_key
+        end
       end
     end
   end

spec/migrations/20240808118000_drop_unique_constraint_quota_definitions_name_key_spec.rb

@@ -6,73 +6,113 @@
     let(:migration_filename) { '20240808118000_drop_unique_constraint_quota_definitions_name_key_spec.rb' }
   end
   describe 'up migration' do
-    context 'the unique constraint on name column exists' do
+    context 'mysql' do
+      before do
+        skip if db.database_type != :mysql
+      end
+
       it 'removes the unique constraint' do
-        if db.database_type == :mysql
-          expect(db.indexes(:quota_definitions)).to include(:name)
-        elsif db.database_type == :postgres
-          expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
-        end
+        expect(db.indexes(:quota_definitions)).to include(:name)
         expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
-        if db.database_type == :mysql
-          expect(db.indexes(:quota_definitions)).not_to include(:name)
-        elsif db.database_type == :postgres
-          expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
-        end
+        expect(db.indexes(:quota_definitions)).not_to include(:name)
       end
 
-      context 'the unique constraint on name column does not exist' do
+      context 'unique constraint on name column does not exist' do
+        before do
+          db.drop_index :quota_definitions, :name, name: :name
+        end
+
         it 'does not throw an error' do
+          expect(db.indexes(:quota_definitions)).not_to include(:name)
           expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
-          if db.database_type == :mysql
-            expect(db.indexes(:quota_definitions)).not_to include(:name)
-          elsif db.database_type == :postgres
-            expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
+          expect(db.indexes(:quota_definitions)).not_to include(:name)
+        end
+      end
+    end
+
+    context 'postgres' do
+      before do
+        skip if db.database_type != :postgres
+      end
+
+      it 'removes the unique constraint' do
+        expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
+        expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
+        expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
+      end
+
+      context 'unique constraint on name column does not exist' do
+        before do
+          db.alter_table :quota_definitions do
+            drop_constraint :quota_definitions_name_key
           end
+        end
+
+        it 'does not throw an error' do
+          expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
           expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
-          if db.database_type == :mysql
-            expect(db.indexes(:quota_definitions)).not_to include(:name)
-          elsif db.database_type == :postgres
-            expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
-          end
+          expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
         end
       end
     end
   end
 
   describe 'down migration' do
-    context 'unique constraint on name column does not exist' do
+    before do
+      Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true)
+    end
+
+    context 'mysql' do
       before do
-        Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true)
+        skip if db.database_type != :mysql
       end
 
       it 'adds the unique constraint' do
-        if db.database_type == :mysql
-          expect(db.indexes(:quota_definitions)).not_to include(:name)
-        elsif db.database_type == :postgres
-          expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
-        end
+        expect(db.indexes(:quota_definitions)).not_to include(:name)
         expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
-        if db.database_type == :mysql
+        expect(db.indexes(:quota_definitions)).to include(:name)
+      end
+
+      context 'unique constraint on name column already exists' do
+        before do
+          Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true)
+
+          db.alter_table :quota_definitions do
+            add_index :name, name: :name
+          end
+        end
+
+        it 'does not fail' do
+          expect(db.indexes(:quota_definitions)).to include(:name)
+          expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
           expect(db.indexes(:quota_definitions)).to include(:name)
-        elsif db.database_type == :postgres
-          expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
         end
       end
     end
 
-    context 'unique constraint on name column does exist' do
-      it 'does not fail' do
+    context 'postgres' do
+      before do
+        skip if db.database_type != :postgres
+      end
+
+      it 'adds the unique constraint' do
+        expect(db.indexes(:quota_definitions)).not_to include(:quota_definitions_name_key)
         expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
-        if db.database_type == :mysql
-          expect(db.indexes(:quota_definitions)).to include(:name)
-        elsif db.database_type == :postgres
-          expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
+        expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
+      end
+
+      context 'unique constraint on name column already exists' do
+        before do
+          Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true)
+
+          db.alter_table :quota_definitions do
+            add_unique_constraint :name, name: :quota_definitions_name_key
+          end
         end
-        expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
-        if db.database_type == :mysql
-          expect(db.indexes(:quota_definitions)).to include(:name)
-        elsif db.database_type == :postgres
+
+        it 'does not fail' do
+          expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
+          expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
           expect(db.indexes(:quota_definitions)).to include(:quota_definitions_name_key)
         end
       end