Fix application rename with CNB lifecycle (#4206)

* Fix application rename with CNB lifecycle * Simplified new code --------- Co-authored-by: Ralf Pannemans <[email protected]>
cloudfoundry · Feb 12, 2025 · 47cc2d3 · 47cc2d3
1 parent 0fcb815
commit 47cc2d3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/cloud_controller/diego/lifecycles/app_cnb_lifecycle.rb b/lib/cloud_controller/diego/lifecycles/app_cnb_lifecycle.rb
@@ -16,7 +16,7 @@ def create_lifecycle_data_model(app)
     end
 
     def valid?
-      !buildpacks.empty?
+      message.is_a?(AppUpdateMessage) || !buildpacks.empty?
     end
 
     def errors

diff --git a/spec/unit/lib/cloud_controller/diego/lifecycles/app_cnb_lifecycle_spec.rb b/spec/unit/lib/cloud_controller/diego/lifecycles/app_cnb_lifecycle_spec.rb
@@ -102,6 +102,14 @@ module VCAP::CloudController
         it 'invalid' do
           expect(lifecycle.valid?).to be(false)
         end
+
+        context 'during an update' do
+          let(:message) { VCAP::CloudController::AppUpdateMessage.new(request) }
+
+          it 'valid' do
+            expect(lifecycle.valid?).to be(true)
+          end
+        end
       end
 
       context 'with buildpacks' do