Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test: Fix regex for timezone parsing [main] #3378

Merged

Conversation

hoffmaen
Copy link
Contributor

@hoffmaen hoffmaen commented Jan 27, 2025

Description of the Change

The unit tests failed on my local system with time zone CEST, as the output is checked against a regex expression that only accepts time zones with three characters. This pull-request allows time zones with three or four characters.

Why Is This PR Valuable?

Unit tests will run on CEST systems.

Applicable Issues

none

How Urgent Is The Change?

Not urgent, it only fixes test issues on local systems.

Other Relevant Parties

none

@hoffmaen hoffmaen changed the title Unit test: Fix regex for timezone parsing to support 3-4 chars Unit test: Fix regex for timezone parsing [main] Jan 27, 2025
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 7f104db into cloudfoundry:main Jan 31, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants