Integrate fips validation #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use refactored update-stemcell-ops task to determine stemcell version * new ops file "operations/fips-stemcell.yml" to maintain version and as trigger for cf-deployment pipeline
jochenehret
force-pushed
the
integrate_fips_validation
branch
from
5a7ff2c to
6f63db1
Compare
|
Pipeline has already been updated, but update-stemcell jobs have been paused until cloudfoundry/runtime-ci#358 is merged. |
3 tasks
|
Are we sure that we want to create an ops file if no one can actually use it without the password? |
ctlong
approved these changes
Apr 25, 2024
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
ctlong
requested changes
Apr 25, 2024
ctlong
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
New ops file for replacing the default stemcell with a versioned FIPS stemcell. New job in "update-releases" pipeline to update the stemcell version.
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
Alana wants to have the FIPS stemcell validation integrated into the cf-deployment validate lifecycle.
Please provide any contextual information.
#1140
Has a cf-deployment including this change passed cf-acceptance-tests?
N/A
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
Not relevant for release notes.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
New Concourse job works: https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/update-releases/jobs/update-fips-stemcell/
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!