No longer require manifest param on delete

#34
cloudfoundry · Dec 13, 2017 · f8ca6dd · f8ca6dd
1 parent 5c31dc0
commit f8ca6dd
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -184,7 +184,6 @@ deployment manifest and then deploy.
 # Delete
 - put: staging
   params:
-    manifest: path/to/manifest.yml
     delete:
       enabled: true
       force: true

diff --git a/concourse/out_request.go b/concourse/out_request.go
@@ -36,7 +36,7 @@ func NewOutRequest(request []byte, sourcesDir string) (OutRequest, error) {
 func checkRequiredOutParameters(params OutParams) error {
 	missingParameters := []string{}
 
-	if params.Manifest == "" {
+	if params.Manifest == "" && !params.Delete.Enabled {
 		missingParameters = append(missingParameters, "manifest")
 	}
 

diff --git a/concourse/out_request_test.go b/concourse/out_request_test.go
@@ -185,6 +185,27 @@ var _ = Describe("NewOutRequest", func() {
 		})
 	})
 
+	Context("when delete is specified", func() {
+		It("does not require the manifest parameter", func() {
+			config := []byte(`{
+				"source": {
+					"deployment": "mydeployment",
+					"target": "director.example.com",
+					"client": "foo",
+					"client_secret": "foobar"
+				},
+				"params": {
+					"delete": {
+						"enabled": true
+					}
+				}
+			}`)
+
+			_, err := concourse.NewOutRequest(config, "")
+			Expect(err).NotTo(HaveOccurred())
+		})
+	})
+
 	Context("when a required parameter is missing", func() {
 		It("returns an error with each missing parameter", func() {
 			config := []byte(`{