Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply tags on stemcell creation #177

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DennisAhausSAP
Copy link

@DennisAhausSAP DennisAhausSAP commented Feb 12, 2025

This PR corresponds to cloudfoundry/bosh#2603

Copy link

linux-foundation-easycla bot commented Feb 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@stefanlay
Copy link
Member

/easycla

@DennisAhausSAP DennisAhausSAP marked this pull request as ready for review February 18, 2025 08:07
Copy link

@a-hassanin a-hassanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - But please remove the assignment 'stemcell=' cloud_v1.rb:520
==> See failed Specs check @DennisAhausSAP

@beyhan
Copy link
Member

beyhan commented Feb 20, 2025

This depends on cloudfoundry/bosh#2603

@beyhan beyhan requested review from a team, lnguyen and rajathagasthya and removed request for a team February 20, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Review | Discussion
Development

Successfully merging this pull request may close these issues.

4 participants