Quote all proxy environment variables in CPI job

- also fail if error occurs (`set -e`) [#128004109](https://www.pivotaltracker.com/story/show/128004109) Signed-off-by: Lyle Franklin <[email protected]>
cloudfoundry · Aug 10, 2016 · 47f0309 · 47f0309
1 parent bf0d4d1
commit 47f0309
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/jobs/aws_cpi/templates/cpi.erb b/jobs/aws_cpi/templates/cpi.erb
@@ -1,21 +1,23 @@
 #!/bin/bash
 
+set -e
+
 BOSH_PACKAGES_DIR=${BOSH_PACKAGES_DIR:-/var/vcap/packages}
 BOSH_JOBS_DIR=${BOSH_JOBS_DIR:-/var/vcap/jobs}
 
 <% if_p('env.http_proxy') do |http_proxy| %>
-export HTTP_PROXY=<%= http_proxy %>
-export http_proxy=<%= http_proxy %>
+export HTTP_PROXY="<%= http_proxy %>"
+export http_proxy="<%= http_proxy %>"
 <% end %>
 
 <% if_p('env.https_proxy') do |https_proxy| %>
-export HTTPS_PROXY=<%= https_proxy %>
-export https_proxy=<%= https_proxy %>
+export HTTPS_PROXY="<%= https_proxy %>"
+export https_proxy="<%= https_proxy %>"
 <% end %>
 
 <% if_p('env.no_proxy') do |no_proxy| %>
-export NO_PROXY=<%= no_proxy %>
-export no_proxy=<%= no_proxy %>
+export NO_PROXY="<%= no_proxy %>"
+export no_proxy="<%= no_proxy %>"
 <% end %>
 
 <% if_p('aws.connection_options.ca_cert') do %>