skip network resolution if prefix defined #351
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
fmoehler
force-pushed
the
enable-ip-prefixes
branch
from
3d40670 to
84a5c30
Compare
fmoehler
force-pushed
the
enable-ip-prefixes
branch
6 times, most recently
from
af01db3 to
9795954
Compare
fmoehler
force-pushed
the
enable-ip-prefixes
branch
from
9795954 to
f6ad119
Compare
aramprice
reviewed
May 8, 2025
platform/linux_platform.go
Outdated
Comment on lines
1533
to
1534
| func (p linux) GetDefaultNetwork(ipv6 bool) (boshsettings.Network, error) { | ||
| return p.defaultNetworkResolver.GetDefaultNetwork(ipv6) |
There was a problem hiding this comment.
Rather than having a bool hear could boshsettings.Network be changed to include IP version information?
It seems odd for the IPv6-ness of the network to be communicated in a way that is disjoint from Network itself.
aramprice
reviewed
May 8, 2025
platform/net/ip/ip_resolver.go
Outdated
| @@ -20,6 +20,7 @@ func NetworkInterfaceToAddrsFunc(interfaceName string) ([]gonet.Addr, error) { | |||
| type Resolver interface { | |||
| // GetPrimaryIPv4 always returns error unless IPNet is found for given interface | |||
| GetPrimaryIPv4(interfaceName string) (*gonet.IPNet, error) | |||
| GetPrimaryIPv6(interfaceName string) (*gonet.IPNet, error) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network Resolution only works for single IPs and not for prefixes, as they do not show with the 'ip' commands. Therefore we skip the resolution if a prefix is defined in a network other then the one for single ips /32 and /128