feat(scalingengine): Integrate cf api with scalingengine #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Silvestre Zabala <[email protected]>
Co-authored-by: Silvestre Zabala <[email protected]>
• Remove direct sha256 usage in PublicApiHandler and replace with new auth.Cert abstraction. • Add auth.NewCert and auth.Cert.GetXFCCHeader to manage certificate encoding and header creation. • Update PublicApiHandler and tests to use the new auth.Cert methods for setting the X-Forwarded-Client-Cert header. • Adjust testhelpers.GenerateClientCert and testhelpers.SetXFCCCertHeader to align with new certificate handling logic.
…ScalingPolicy function.
- handle CF_INSTANCE_CERT and CF_INSTANCE_KEY - Remove `CfInstanceCert` from `Config` struct and related code - Generate RSA keys and certificates for testing in `api_test.go` and `config_test.go` - Set environment variables for instance keys and certs in tests - Update `config#configureEventGenerator` to use environment variables for TLS config - Remove unused `auth` import and related code in `public_api_handler.go` - Create `MaterializeContentInFile` function in `configutil` for file operations - Add `GenerateClientCertWithPrivateKey` and `GenerateClientKeyWithPrivateKey` in `testhelpers`
…n PublicApiHandler
• Eliminate GetCfInstanceCert method and associated environment variable usage. • Update tests to reflect removal of CF_INSTANCE_CERT handling.
bonzofenix
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Patches TLS config to send identity cert provided by cf when API component performs a request to scaling engine
Key changes
scaling_historiesendpoint.