Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(healthendpoint): Refactor health endpoint in all services to run on same port as main service #3028

Open
wants to merge 99 commits into
base: main
Choose a base branch
from

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    1133a9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a9ba97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4cf6e6e View commit details
    Browse the repository at this point in the history
  4. Remove blank line

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3f38a5c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d5647c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ed7f8a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c265c4f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    be848a0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a04beb3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1b11887 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    55de5bf View commit details
    Browse the repository at this point in the history
  12. Remove unused comments

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    80c0f74 View commit details
    Browse the repository at this point in the history
  13. Remove useless assertion

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    edfe744 View commit details
    Browse the repository at this point in the history
  14. Remove irrelevant tesT

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d68c6bd View commit details
    Browse the repository at this point in the history
  15. Fix Lint warning

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    37dd006 View commit details
    Browse the repository at this point in the history
  16. Remove unused variables

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    909ab20 View commit details
    Browse the repository at this point in the history
  17. Remove unused variables

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    77fc5ac View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    43da986 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    47cd30c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    c77c0a0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d345dc3 View commit details
    Browse the repository at this point in the history
  22. Update spec/jobs/operator/operator_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    660f72e View commit details
    Browse the repository at this point in the history
  23. Update spec/jobs/operator/operator_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f66f4db View commit details
    Browse the repository at this point in the history
  24. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8bd85ab View commit details
    Browse the repository at this point in the history
  25. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1cd50d3 View commit details
    Browse the repository at this point in the history
  26. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    13822ae View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    2d1743a View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    63aab06 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    94edb9c View commit details
    Browse the repository at this point in the history
  30. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fe9c6df View commit details
    Browse the repository at this point in the history
  31. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6dd12bb View commit details
    Browse the repository at this point in the history
  32. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d6564e8 View commit details
    Browse the repository at this point in the history
  33. Update spec/jobs/scalingengine/scalingengine_spec.rb

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    bonzofenix and github-actions[bot] committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ad08b60 View commit details
    Browse the repository at this point in the history
  34. Fix broken test

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6310330 View commit details
    Browse the repository at this point in the history
  35. Fix spec lint

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4cfed72 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    c3157dc View commit details
    Browse the repository at this point in the history
  37. Remove empty lines

    bonzofenix committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f38ef14 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    837ff13 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    2f4e595 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    6ef31ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da2591b View commit details
    Browse the repository at this point in the history
  3. Fix lints

    bonzofenix committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    10c3979 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    ec1363a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cce83f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99e9779 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Fix operator tests

    bonzofenix committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    003fd7b View commit details
    Browse the repository at this point in the history
  2. Fix rspec

    bonzofenix committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7978293 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    845082c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b6763dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f46e06 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a7d9457 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2d935bc View commit details
    Browse the repository at this point in the history
  8. Fix integration build

    bonzofenix committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    49b473f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5520621 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    0c50fac View commit details
    Browse the repository at this point in the history
  2. feature/754-healthendpoint-service-refactor: Remove TLS configuration…

    … and switch to HTTP for all components
    
     • Eliminate TLS-related configurations from BrokerServer, PublicApiServer, and various server components across the codebase.
     • Update API tests to use HTTP instead of HTTPS for requests.
     • Remove unused filepath import from api_suite_test.go.
    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ee91058 View commit details
    Browse the repository at this point in the history
  3. feature/754-healthendpoint-service-refactor: Add GINKGO_OPTS to integ…

    …ration target in Makefile for autoscaler component
    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    51160f3 View commit details
    Browse the repository at this point in the history
  4. feature/754-healthendpoint-service-refactor: Remove TLS configuration…

    … from Golang API server and replace specific TLS clients with generic clients in test helpers.
    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5b98861 View commit details
    Browse the repository at this point in the history
  5. Updated integration tests to use URL struct for API endpoints

     Changed function signatures to accept URL instead of port number for API calls.
     Fixed issues with attaching and detaching policies by updating the corresponding test functions to use the new URL parameter.
     Added checks for active schedules in the scaling engine and ensured proper synchronization of schedules between the scheduler and scaling engine.
    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d7dd4ea View commit details
    Browse the repository at this point in the history
  6. feature/754-healthendpoint-service-refactor: Add basic auth configura…

    …tion to Scheduler and remove SSL settings from template
    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ccda2d0 View commit details
    Browse the repository at this point in the history
  7. feature/754-healthendpoint-service-refactor: Remove TLS configuration…

    … from BrokerServer in integration tests
    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b7c99e1 View commit details
    Browse the repository at this point in the history
  8. Fix lints

    bonzofenix committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4c62841 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. feature/754-healthendpoint-service-refactor: Remove GetScalingHistori…

    …es function from public_api_handler in autoscaler API
    bonzofenix committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ffbd160 View commit details
    Browse the repository at this point in the history
  2. Refactor security handling in scaling history API

     - Introduce SecuritySource struct to handle security for scaling history endpoints
     - Replace direct usage of ScalingHistoryHandler with SecuritySource for security interfaces
     - Update scaling history client creation to use SecuritySource and internal scaling engine history client
     - Remove redundant BearerAuth and HandleBearerAuth methods from ScalingHistoryHandler
     - Implement BearerAuth and HandleBearerAuth in SecuritySource for mTLS authentication
     - Adjust V1AppsGUIDScalingHistoriesGet to use new internal client and parameters mapping
    bonzofenix committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    080494e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bbd2e7f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    930a5d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Refactor scaling history client creation and authentication

     • Replace direct server dependency with client in ScalingHistoryHandler.
     • Implement TransportWithBasicAuth for HTTP client basic auth handling.
     • Add SecuritySource struct in client package for basic auth credentials.
     • Remove unnecessary BasicAuth method from SecuritySource in server package.
    bonzofenix committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6c5ac88 View commit details
    Browse the repository at this point in the history
  2. Add GinkgoHelper calls and refactor HTTP clients for scheduler integ…

    …ration tests
    
     - Introduce GinkgoHelper function calls in helpers_test.go for better test output.
     - Replace httpClientForPublicApi with httpClientForScheduler for clarity in integration_golangapi_scheduler_test.go.
     - Update httpClient usage in integration_suite_test.go to use the new httpClientForScheduler for scheduler-related requests.
    bonzofenix committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ce3cee0 View commit details
    Browse the repository at this point in the history
  3. Fix an integration test

    bonzofenix committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3fe8eba View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    4d9ed1f View commit details
    Browse the repository at this point in the history
  2. Remove unused imports

     - Eliminate unnecessary SSL and HTTP client configuration code from RestClientConfig
     - Clean up imports in ConcurrentRequestTest
    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ee2793c View commit details
    Browse the repository at this point in the history
  3. Refactor integration tests to use separate HTTP clients for public AP…

    …I and scheduler
    
     • Introduced httpClientForPublicApi and httpClientForScheduler to differentiate between clients in integration tests.
     • Updated detachPolicy and doAttachPolicy calls to use httpClientForPublicApi instead of the generic httpClient.
    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    71505a9 View commit details
    Browse the repository at this point in the history
  4. Refactor and fix failing in scheduler scalingengine integration test

     • Rename httpClient to httpClientForScheduler for clarity in integration tests.
     • Update error handling to provide more context in checkResponseEmptyAndStatusCode function.
    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    de3d785 View commit details
    Browse the repository at this point in the history
  5. Fix lint

    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    15db978 View commit details
    Browse the repository at this point in the history
  6. Refactor event generator credentials to use constants and remove redu…

    …ndant httpClientTmp in integration tests.
    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    20254e4 View commit details
    Browse the repository at this point in the history
  7. Refactor HTTP client creation and usage across tests

     - Replace `NewApiClient` with `NewPublicApiClient` for consistency.
     - Add `NewScalingEngineClient` for specific scaling engine tests.
     - Update HTTP client variable names to reflect their specific use cases.
    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    924acaf View commit details
    Browse the repository at this point in the history
  8. Fix java format

    bonzofenix committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d6f4216 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Syncs package specs

    - Add scaling history API and client to golangapiserver and scalingengine packages
    bonzofenix committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    70cdd58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fb387a View commit details
    Browse the repository at this point in the history
  3. Refactor integration tests and improve URL parameter handling

     * Fix failing integration text
     • Update integration tests to remove unnecessary space in test description.
     • Refactor URL construction in getAppAggregatedMetrics to use RawQuery for cleaner parameter handling.
    bonzofenix committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7a1fe64 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cc77611 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    514461d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a1167a2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d586408 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eb4428c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Fixed server configuration block and added credentials for scaling en…

    …gine in app-autoscaler.yml
    bonzofenix committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    df245ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    013a25b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b086dca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e0ac0a4 View commit details
    Browse the repository at this point in the history
  5. Refactor API tests and helpers to use dynamic URL construction

     - Remove hardcoded paths and replace with dynamic URL construction using `fmt.Sprintf` and `url.Parse`
     - Consolidate constants for API paths into the tests where they are used
     - Eliminate unused variables and imports following the URL refactoring
     - Update functions to construct URLs dynamically before making HTTP requests
    bonzofenix committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    bf33a99 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    3f1d58f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    080ece1 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    45d9256 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23e4dd8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    802b76c View commit details
    Browse the repository at this point in the history
  2. Refactor server tests to use url.URL and simplify request setup

     • Update tests to construct serverUrl as a url.URL object instead of a string.
     • Simplify the request setup by removing redundant helper functions and using setupRequest directly.
     • Set basic auth credentials on the request using SetBasicAuth method.
     • Adjust serverUrl.Path for each test case to point to the correct endpoint.
    bonzofenix committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e137846 View commit details
    Browse the repository at this point in the history
  3. Refactor server_test.go to use req.SetBasicAuth and replace Context w…

    …ith When for test descriptions
    bonzofenix committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b5d87df View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6aab865 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    e5a2783 View commit details
    Browse the repository at this point in the history