feat(devbox): Build image #2943
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
silvestre
commented
May 22, 2024
•
silvestre
commented
- feat(devbox): Add Cloud MTA Build Tool to devbox
- feat(devbox): Build image
# Issue For building MTAs the Cloud MTA Build Tool is required. # Fix Add it via local flake
# Issue To switch over our CI workflows to devbox a docker image is required. # Fix Build it from the Dockerfile generated with `devbox generate dockerfile`
silvestre
force-pushed
the
add-devbox-image
branch
from
6a3e6e8 to
34a22f6
Compare
silvestre
added
exclude-from-changelog
allow-acceptance-tests
geigerj0
reviewed
May 22, 2024
geigerj0
reviewed
May 22, 2024
geigerj0
reviewed
May 22, 2024
geigerj0
reviewed
May 22, 2024
geigerj0
reviewed
May 22, 2024
# Issue The image name was constructed multiple times. # Fix Use `IMAGE_NAME` environment variable
# Issue jetify-com/devbox#2073 # Fix Remove step number.
# Issue - `sap-piper` is not needed at the moment. - `mbt` was cryptically named. # Fix - Remove `sap-piper` - Rename `mbt` to the name of the repo
# Issue `credhub` is not part of `.tool-versions`, so no mapping is needed # Fix Remove `credhub` mapping
silvestre
force-pushed
the
add-devbox-image
branch
from
e8e8bce to
ea75773
Compare
geigerj0
reviewed
May 22, 2024
Comment on lines
-14
to
-17
| for pkg in data['packages']: | ||
| if pkg.startswith(f"{package}@"): | ||
| return pkg.split('@')[1] | ||
| return None |
geigerj0
reviewed
May 22, 2024
| @@ -0,0 +1,18 @@ | |||
| FROM jetpackio/devbox@sha256:430afb5a5c9b4ec9f56776e8fcb82fe67fa5fabba3ba67ebb1c13b17d0e8de8d | |||
There was a problem hiding this comment.
Have you tested if the CI-pipeline required stuff like make acceptance-tests, make test etc. works with this docker image?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.