Skip to content

Implement response size logging #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Implement response size logging #170

merged 2 commits into from
Apr 11, 2025

Conversation

ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Apr 11, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Implement response size logging

Known issue

@ImMin5 ImMin5 added the enhancement New feature or request label Apr 11, 2025
@ImMin5 ImMin5 requested a review from Copilot April 11, 2025 04:25
@ImMin5 ImMin5 self-assigned this Apr 11, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@@ -265,6 +269,23 @@ def _pipeline(
delete_transaction()


def _get_response_size(response_or_iterator: Any) -> int:
try:
print(type(response_or_iterator))
Copy link
Preview

Copilot AI Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the debug print statement or replace it with _LOGGER.debug to prevent unintended output in production.

Suggested change
print(type(response_or_iterator))
_LOGGER.debug(f"Type of response_or_iterator: {type(response_or_iterator)}")

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@ImMin5 ImMin5 merged commit 164f843 into cloudforet-io:master Apr 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pass/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant