Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed option field name 'options.default_filters' --> 'options.default_filter' to sync with console-api #392

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

kangwork
Copy link
Contributor

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Changed option field name 'options.default_filters' --> 'options.default_filter' to sync with console-api

Known issue

  • Need to discuss the appropriateness of singular naming as we would want to make a field represent lists
  • The current console-api sets a default value as an empty dictionary instead of an empty list (due to isMultiple setup), and those default values are inconsistent within the repository(console-api)

…default_filter' to sync with console-api

Signed-off-by: kangwork <[email protected]>
@kangwork kangwork merged commit 05bb6ae into cloudforet-io:master Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant