-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added remaining routes and fixed tests #473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apting some improvements from the latest version.
…apting some improvements from the latest version - fmt.
3 tasks
@spigaz thanks for putting this together, I'm gonna go ahead and approve and get this all into one PR for review. |
kflansburg
approved these changes
Mar 11, 2024
kflansburg
added a commit
that referenced
this pull request
Mar 11, 2024
* Bump wasm-streams * Use Body::into_readable_stream * fmt * clippy * Remove unused js hack * clippy * Added remaining routes and fixed testes (#473) * Added test script to package.json. * Added worker-sandbox r2 routes. * Added worker-build to the npm test script. * Added worker-sandbox r2 routes - cleanup. * Added worker-sandbox queue routes. * Added worker-sandbox service-bindings routes - implied porting and adapting some improvements from the latest version. * Added worker-sandbox service-bindings routes - implied porting and adapting some improvements from the latest version - fmt. * Added worker-sandbox cache stream route - Implied porting some more recent stuff. * Added worker-sandbox remaining cache routes. * Added worker-sandbox init called route. * Added worker-sandbox custom-response-body route. * Added worker-sandbox now route. * Added worker-sandbox redirect-307 route. * Added worker-sandbox redirect-default route. * Added worker-sandbox subrequests routes and fetch helpers that were requeried. * Added worker-sandbox subrequests fetch-timeout to be shorter. * Added worker-sandbox request catchall fixed test case. * Added worker-sandbox request xor route. * Added worker-sandbox request xor route. * Added worker-sandbox websocket route. * worker-sandbox queue routes clean up. * worker unused dependencies clean up. * worker-sandbox: Added missing d1 routes and improved d1 tests to use miniflare. * worker-sandbox: Clippy. * worker-sandbox: fmt. --------- Co-authored-by: Alexandre Faria <[email protected]>
spigaz
changed the title
Added remaining routes and fixed testes
Added remaining routes and fixed tests
Mar 11, 2024
@kflansburg Thanks! Please do tell if I can help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are all running now, even d1, that now run perfectly on miniflare.
I tried to be as minimal as possible, but I had to port some things from the latest version.
I wasn't sure what was going to be the final API after the final merge, so I tried to minimize impact on rebase or merge.
You asked for the tests, I used your PR 440 as reference, but I couldn't PR to it.
Please tell me how can I help to make things as smooth as possible.
Thanks!