Fix issues with Request.clone in http types #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
force-pushed
the
kflansburg/http
branch
from
2dae0d2 to
e7caadc
Compare
kflansburg
commented
Jan 24, 2024
| @@ -30,3 +30,6 @@ lto = true | |||
| [profile.release.package."*"] | |||
| codegen-units = 1 | |||
| opt-level = "z" | |||
|
|
|||
| [workspace.dependencies] | |||
| wasm-bindgen = "=0.2.87" | |||
There was a problem hiding this comment.
I think it will be easier to set this at the workspace level.
| @@ -10,7 +10,11 @@ use std::{ | |||
| use router_service::unsync::Router; | |||
| use serde::{Deserialize, Serialize}; | |||
| use tower::Service; | |||
| use worker::{body::Body, http::{Response, HttpClone, RequestRedirect}, *}; | |||
| use worker::{ | |||
| wasm-bindgen-futures = "0.4.36" | ||
| serde-wasm-bindgen = "0.5.0" | ||
| wasm-streams = "0.3.0" | ||
| wasm-streams = "0.4.0" |
There was a problem hiding this comment.
This had to be bumped due to incompatibility in ReadableStream types in the prior version (now re-exports web_sys types).
| crate::body::BodyInner::Regular(s) => Some( | ||
| wasm_streams::ReadableStream::from_async_read( | ||
| crate::body::BoxBodyReader::new(s), | ||
| 1024, |
There was a problem hiding this comment.
Idk what to set this default buffer size to
3 tasks
* Added test script to package.json. * Added worker-sandbox r2 routes. * Added worker-build to the npm test script. * Added worker-sandbox r2 routes - cleanup. * Added worker-sandbox queue routes. * Added worker-sandbox service-bindings routes - implied porting and adapting some improvements from the latest version. * Added worker-sandbox service-bindings routes - implied porting and adapting some improvements from the latest version - fmt. * Added worker-sandbox cache stream route - Implied porting some more recent stuff. * Added worker-sandbox remaining cache routes. * Added worker-sandbox init called route. * Added worker-sandbox custom-response-body route. * Added worker-sandbox now route. * Added worker-sandbox redirect-307 route. * Added worker-sandbox redirect-default route. * Added worker-sandbox subrequests routes and fetch helpers that were requeried. * Added worker-sandbox subrequests fetch-timeout to be shorter. * Added worker-sandbox request catchall fixed test case. * Added worker-sandbox request xor route. * Added worker-sandbox request xor route. * Added worker-sandbox websocket route. * worker-sandbox queue routes clean up. * worker unused dependencies clean up. * worker-sandbox: Added missing d1 routes and improved d1 tests to use miniflare. * worker-sandbox: Clippy. * worker-sandbox: fmt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.