-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cache: no-cache compat flag and enum #3195
base: main
Are you sure you want to change the base?
Conversation
bb9478f
to
64003ed
Compare
I'll need some context here to review this well:
|
There are no cases where
In the past this is how we did it because it allowed me to experiment with tests in live workers before we pushed this feature to customers. I think that this same principle of experimentation applies here. There are no internal PRs that are associated with this change yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's be sure to test internally before merging
64003ed
to
7e4252c
Compare
The generated output of Full Type Diffdiff -r bazel-bin/types/definitions/experimental/index.d.ts types/generated-snapshot/experimental/index.d.ts
1680c1680
< cache?: "no-store" | "no-cache";
---
> cache?: "no-store";
1694c1694
< cache?: "no-store" | "no-cache";
---
> cache?: "no-store";
diff -r bazel-bin/types/definitions/experimental/index.ts types/generated-snapshot/experimental/index.ts
1688c1688
< cache?: "no-store" | "no-cache";
---
> cache?: "no-store";
1702c1702
< cache?: "no-store" | "no-cache";
---
> cache?: "no-store"; |
First part of
cache: no-cache
implementation:Note that the actual implementation is incompelete.