[build] Define CI-friendly bazel configuration, silence noisy Windows warnings #2959
+37
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only material change is to add keep_going for all bazel invocations. So far we bailed out early during the build step of the test action based on concerns about runs that rebuild V8 not failing fast, but it feels more useful to keep going to get all of the error messages since V8 rebuilds are rare.
This makes the Windows build log much smaller.
fhanau
force-pushed
the
felix/101924-bazel-ci
branch
from
17649ff
to
c95c4fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build] Define CI-friendly bazel configuration
The only material change is to add keep_going for all bazel invocations. So far
we bailed out early during the build step of the test action based on concerns
about runs that rebuild V8 not failing fast, but it feels more useful to keep
going to get all of the error messages since V8 rebuilds are rare.
[build] Silence noisy Windows warnings
This makes the Windows build log much smaller.