Roll boringssl #2956
Open
Roll boringssl #2956
+36
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #2745. After confirming that the few DH inputs that are now rejected by boringssl are not being actively used, we can return a proper error for them and update the boringssl version for workerd. Even if the version used internally is out-of-sync for now, the added checks here ensure that the behavior is the same. Test cases are updated based on the new behavior.
|
Downstream build (same branch name) passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2745. After confirming that the few cases where DH inputs that are now rejected by boringssl are not being actively used in production, we can return a proper error for them and update the boringssl version for workerd. With the new version, we're moving 13 months forward. Even if the version used internally is out-of-sync for now, the added checks here ensure that the behavior is the same.
Test cases are updated based on the new behavior.