Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add node:querystring to workerd #2944

Merged
merged 1 commit into from
Oct 19, 2024
Merged

add node:querystring to workerd #2944

merged 1 commit into from
Oct 19, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 17, 2024

node:querystring is required to land require('node:url').Url and used widely across many applications. It is in our benefit to move this to the runtime and reduce the size of the polyfills.

@anonrig anonrig requested a review from jasnell October 17, 2024 19:36
@anonrig anonrig requested review from a team as code owners October 17, 2024 19:36
@anonrig anonrig merged commit 0617740 into main Oct 19, 2024
13 checks passed
@anonrig anonrig deleted the yagiz/add-node-querystring branch October 19, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@vickykont vickykont Awaiting requested review from vickykont vickykont is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @jasnell