VS-284: Add Bindings support for Vectorize queryById operation #2941
+99
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garvit-gupta
force-pushed
the
garvit/VS-284/query-by-id
branch
from
f01cbdc
to
02a339d
Compare
netgusto
approved these changes
Oct 17, 2024
garrettgu10
approved these changes
Oct 17, 2024
| if (this.indexVersion === 'v1') { | ||
| throw new Error(`QueryById operation is not supported for v1 indexes.`); | ||
| } else { | ||
| if (options?.returnMetadata) { |
There was a problem hiding this comment.
Can we factor out this duplicate code between query() and queryById()? Something like a queryImpl() that accepts an object that contains either a vector or vectorId field, then spreads the object into the body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Vectorize operation for Bindings:
queryById()that allows users to query their index using a vector already present in the index.