Reuse ActorContainerRef if it exists #2011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a Durable Object in Workerd (local dev/miniflare) hibernated (i.e. Worker::Actor was destroyed), but the stub wasn't dropped by the worker (i.e. PromisedWorkerInterface still alive), then we would incorrectly create an entirely new refcounted ActorContainerRef upon a new request coming in.
This is incorrect because the old ActorContainerRef is still owned, and by creating an entirely separate one, we break our request tracking.
Specifically, the ActorContainer only tracks a weak reference to an ActorContainerRef, and so if we have two separate ActorContainerRef's one of them will not be tracked.