Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach the kj::Path in alarm-scheduler.c++ #1442

Closed
wants to merge 1 commit into from
Closed

Attach the kj::Path in alarm-scheduler.c++ #1442

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 27, 2023

This is an attempt to fix #1386

@jasnell jasnell mentioned this pull request Nov 27, 2023
Closed
@jasnell jasnell requested a review from kentonv November 27, 2023 21:42
@kentonv
Copy link
Member

kentonv commented Nov 29, 2023

I checked the implementation of SqliteDatabase, and it does not appear to hold onto the PathPtr beyond the constructor, so I think this change doesn't have any effect.

@jasnell jasnell closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentonv kentonv Awaiting requested review from kentonv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report — Runtime APIs: alarm-scheduler fails for inscrutable reason
2 participants
@jasnell @kentonv