Provide WebSocket ready state constants to follow the Web IDL definition #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-mp
approved these changes
Nov 6, 2023
jqmmes
approved these changes
Nov 6, 2023
MellowYarker
approved these changes
Nov 6, 2023
jasnell
reviewed
Dec 18, 2023
src/workerd/api/web-socket.h
Outdated
| @@ -428,9 +428,16 @@ class WebSocket: public EventTarget { | |||
| JSG_METHOD(deserializeAttachment); | |||
|
|
|||
| JSG_STATIC_CONSTANT(READY_STATE_CONNECTING); | |||
| JSG_STATIC_CONSTANT_ALIAS(CONNECTING, WebSocket::READY_STATE_CONNECTING); | |||
There was a problem hiding this comment.
LGTM but I think JSG_STATIC_CONSTANT_NAMED would probably align better with some of the other macros
There was a problem hiding this comment.
bcaimano
force-pushed
the
bcaimano/web-socket-ready-state
branch
from
02323e2
to
d96d644
Compare
bcaimano
force-pushed
the
bcaimano/web-socket-ready-state
branch
from
d96d644
to
2821742
Compare
jasnell
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1370. I also added in a little macro so that we could reuse the existing constants for both new and old js constants.