Unblock rules_ts update, clean up unused tsconfig.json files

cloudflare · Oct 18, 2024 · 3741817 · 3741817
1 parent b6bc9cf
commit 3741817
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 57 deletions.
diff --git a/build/deps/build_deps.jsonc b/build/deps/build_deps.jsonc
@@ -113,9 +113,7 @@
       "type": "github_release",
       "owner": "aspect-build",
       "repo": "rules_ts",
-      "file_regex": "^rules_ts-",
-      // TODO(cleanup): Unpinning causes http-test@ts_project_typecheck_test to fail on Windows
-      "freeze_version": "v3.1.0"
+      "file_regex": "^rules_ts-"
     }
   ]
 }
diff --git a/build/deps/gen/dep_aspect_rules_ts.bzl b/build/deps/gen/dep_aspect_rules_ts.bzl
@@ -2,10 +2,10 @@
 
 load("@//:build/http.bzl", "http_archive")
 
-TAG_NAME = "v3.1.0"
-URL = "https://github.com/aspect-build/rules_ts/releases/download/v3.1.0/rules_ts-v3.1.0.tar.gz"
-STRIP_PREFIX = "rules_ts-3.1.0"
-SHA256 = "5aafa2422b6f2ed6d8db9edcd6368693055960bca7e149516b95c0d45a6a7ae5"
+TAG_NAME = "v3.2.1"
+URL = "https://github.com/aspect-build/rules_ts/releases/download/v3.2.1/rules_ts-v3.2.1.tar.gz"
+STRIP_PREFIX = "rules_ts-3.2.1"
+SHA256 = "8bbac753f4b61adbfc1d9878b87b9cd0f64c9e8e6d8fafc8a1bbfa9625bab162"
 TYPE = "tgz"
 
 def dep_aspect_rules_ts():

diff --git a/src/cloudflare/internal/test/images/tsconfig.json b/src/cloudflare/internal/test/images/tsconfig.json
diff --git a/src/cloudflare/internal/test/pipeline-transform/tsconfig.json b/src/cloudflare/internal/test/pipeline-transform/tsconfig.json
diff --git a/src/cloudflare/internal/test/vectorize/tsconfig.json b/src/cloudflare/internal/test/vectorize/tsconfig.json
diff --git a/src/workerd/api/BUILD.bazel b/src/workerd/api/BUILD.bazel
@@ -520,8 +520,9 @@ wd_test(
 ts_project(
     name = "http-test@ts_project",
     srcs = ["http-test-ts.ts"],
-    allow_js = True,
     composite = True,
+    # The declarations here are not being used anywhere, but this is needed due to https://github.com/aspect-build/rules_ts/issues/128
+    declaration = True,
     source_map = True,
     tsconfig = "tsconfig.json",
     deps = ["//src/node:node.capnp@tsproject"],

diff --git a/src/workerd/api/tsconfig.json b/src/workerd/api/tsconfig.json
@@ -5,16 +5,12 @@
     "strict": true,
     "moduleResolution": "node",
     "esModuleInterop": true,
-    "outDir": "dist",
     "sourceMap": true,
-    "baseUrl": ".",
-    "rootDir": ".",
     "paths": {
       "@workerd/*": ["../../bazel-bin/src/workerd/*"]
     },
-    "checkJs": true,
-    "allowJs": true,
     "composite": true,
+    "declaration": true,
     "skipLibCheck": true
   },
   "include": ["**/*.ts"],

diff --git a/types/src/worker/tsconfig.json b/types/src/worker/tsconfig.json