-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Leaked Credential Check Rules resource #4676
Add Leaked Credential Check Rules resource #4676
Conversation
changelog detected ✅ |
} | ||
zoneID := cloudflare.ZoneIdentifier(plan.ZoneID.ValueString()) | ||
// fetch existing rules from API | ||
existing_rules, err := r.client.V1.LeakedCredentialCheckListDetections(ctx, zoneID, cloudflare.LeakedCredentialCheckListDetectionsParams{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this functionality isn't going to be ported to v5 as it is custom handling of the payloads. is there a reason this cannot be achieved using the schema and remote service?
return | ||
} | ||
|
||
func diffRules(desired []LCCRuleValueModel, current []cloudflare.LeakedCredentialCheckDetectionEntry) (toAdd []cloudflare.LeakedCredentialCheckCreateDetectionParams, toRemove []cloudflare.LeakedCredentialCheckDeleteDetectionParams, toKeep []cloudflare.LeakedCredentialCheckDetectionEntry) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'd like to avoid needing this is v5. is there a reason why we don't have the API modelled in a way that this is inbuild and uses a PUT/DELETE correctly?
fd87915
to
8a4727e
Compare
5e4c035
to
526b324
Compare
This functionality has been released in v4.48.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This PR creates a new resource for managing the Leaked Credential Check Rules API.
Running Acceptance Test requires both using cloudflare-go unreleased changes and including the changes from the terraform-provider-cloudflare Leaked Credential Check PR. The Leaked Credential Check PR should be first merged into master and then into this PR.
Tests