Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare worker secret resource #3035

Merged
merged 50 commits into from
Jan 4, 2024

Conversation

lboynton
Copy link
Contributor

@lboynton lboynton commented Jan 3, 2024

Reopening again after #2628 was marked as stale.

helenatuominen and others added 30 commits November 17, 2020 18:04
lboynton and others added 16 commits October 23, 2023 12:11
Tests fail with:

=== RUN   TestAccCloudflareWorkerSecret_Import
    import_cloudflare_worker_secret_test.go:17: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.

          map[string]string{
        - 	"secret_text": "pfeasocioh",
          
This is currently failing because the secret_text is not set, but this is not returned from the API so I'm not sure how to resolve this
…ecret

# Conflicts:
#	internal/sdkv2provider/provider.go
@lboynton lboynton requested a review from jacobbednarz as a code owner January 3, 2024 20:21
Copy link
Contributor

github-actions bot commented Jan 3, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareWorkerSecret_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareWorkerSecret_Basic
=== PAUSE TestAccCloudflareWorkerSecret_Basic
=== CONT  TestAccCloudflareWorkerSecret_Basic
--- PASS: TestAccCloudflareWorkerSecret_Basic (13.46s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	13.889s

@jacobbednarz jacobbednarz merged commit 92a13dd into cloudflare:master Jan 4, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.22.0 milestone Jan 4, 2024
github-actions bot pushed a commit that referenced this pull request Jan 4, 2024
@jacobbednarz
Copy link
Member

thanks for this @lboynton! fyi, the previous PR was closed because there weren't any updates in 14 days and was still marked as in progress (a comment on there would have kept it open).

@lboynton
Copy link
Contributor Author

lboynton commented Jan 4, 2024

Awesome, thanks @jacobbednarz! 🚀

Copy link
Contributor

This functionality has been released in v4.22.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants