resource/cloudflare_list_item: ensure each entry gets a unique ID #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the List service using a polling model and not exposing the resource ID at creation, the provider relied on the assumption that it would be the latest created entry. This however, is incorrect as if you have multiple items added to a single list, they will all share the same ID of the last inserted entry. To rectify this, we (inefficiently) use a second API call to search for the list item after the polling operation has completed to return the unique ID. This is easiest demonstrated by the IDs outputted by `terraform` when applying changes. Without this fix ``` $ terraform apply cloudflare_list.example: Creating... cloudflare_list.example: Creation complete after 0s [id=20443923226b42268668e85b2f968532] cloudflare_list_item.example_4: Creating... cloudflare_list_item.example_3: Creating... cloudflare_list_item.example_1: Creating... cloudflare_list_item.example_2: Creating... cloudflare_list_item.example_3: Creation complete after 4s [id=495e8b0f37fd4b9f8ceead7b15e783ad] cloudflare_list_item.example_1: Creation complete after 5s [id=495e8b0f37fd4b9f8ceead7b15e783ad] cloudflare_list_item.example_2: Creation complete after 5s [id=495e8b0f37fd4b9f8ceead7b15e783ad] cloudflare_list_item.example_4: Creation complete after 6s [id=495e8b0f37fd4b9f8ceead7b15e783ad] ``` And after this fix ``` $ terraform apply cloudflare_list.example: Creating... cloudflare_list.example: Creation complete after 0s [id=a2679b7940624b9aba3ad9987441d281] cloudflare_list_item.example_4: Creating... cloudflare_list_item.example_3: Creating... cloudflare_list_item.example_1: Creating... cloudflare_list_item.example_2: Creating... cloudflare_list_item.example_3: Creation complete after 4s [id=bdf686681b654aeab7555fc12be38fb6] cloudflare_list_item.example_1: Creation complete after 5s [id=68ebd2f8e1c445fd9bcd55a3cb11b692] cloudflare_list_item.example_2: Creation complete after 5s [id=e8c84aa699dc4f9297b08b0891342e26] cloudflare_list_item.example_4: Creation complete after 6s [id=a804fba7f3a546198cb58a8f69060964] ```
|
changelog detected ✅ |
|
acceptance tests all passing |
|
Hello, when will we be able to use 4.19 version with fix of this bug? |
|
This functionality has been released in v4.19.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the List service using a polling model and not exposing the resource ID at creation, the provider relied on the assumption that it would be the latest created entry. This however, is incorrect as if you have multiple items added to a single list, they will all share the same ID of the last inserted entry.
To rectify this, we (inefficiently) use a second API call to search for the list item after the polling operation has completed to return the unique ID. This is easiest demonstrated by the IDs outputted by
terraformwhen applying changes.Without this fix
And after this fix
Closes #2559
Closes #2848