Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the use of Additional Cacheable Ports in Cache Rules #2854

Merged

Conversation

foreseaz
Copy link
Member

Taking over fixing #2754

Local test passed TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/acctest    [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/framework/expanders        [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/consts     [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/framework/flatteners       [no test files]
?       github.com/cloudflare/terraform-provider-cloudflare/internal/framework/modifiers/defaults       [no test files]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/provider 0.295s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/api_token_permissions_groups     0.715s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/example  0.509s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/r2_bucket        0.450s [no tests to run]
=== RUN   TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty
--- PASS: TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty (3.15s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets 3.962s
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/turnstile        0.962s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/user     1.398s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider      1.185s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/utils      1.185s [no tests to run]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

changelog detected ✅

@foreseaz foreseaz force-pushed the chenxi/additional-cacheable-ports branch from 5005765 to 9432a38 Compare October 17, 2023 00:38
@jacobbednarz
Copy link
Member

acceptance tests all looking good thanks!

TF_ACC=1 go test ./internal/framework/service/rulesets -v -run "^TestAccCloudflareRuleset_Cache" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareRuleset_CacheSettingsAllEnabled
--- PASS: TestAccCloudflareRuleset_CacheSettingsAllEnabled (10.60s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty
--- PASS: TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty (10.01s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsEdgeTTLRespectOrigin
--- PASS: TestAccCloudflareRuleset_CacheSettingsEdgeTTLRespectOrigin (9.57s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsNoCacheForStatus
--- PASS: TestAccCloudflareRuleset_CacheSettingsNoCacheForStatus (9.76s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsStatusRangeGreaterThan
--- PASS: TestAccCloudflareRuleset_CacheSettingsStatusRangeGreaterThan (9.60s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsStatusRangeLessThan
--- PASS: TestAccCloudflareRuleset_CacheSettingsStatusRangeLessThan (10.16s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsFalse
--- PASS: TestAccCloudflareRuleset_CacheSettingsFalse (9.32s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsMissingEdgeTTLWithOverrideOrigin
--- PASS: TestAccCloudflareRuleset_CacheSettingsMissingEdgeTTLWithOverrideOrigin (1.84s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsMissingBrowserTTLWithOverrideOrigin
--- PASS: TestAccCloudflareRuleset_CacheSettingsMissingBrowserTTLWithOverrideOrigin (1.69s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsInvalidEdgeTTLWithOverrideOrigin
--- PASS: TestAccCloudflareRuleset_CacheSettingsInvalidEdgeTTLWithOverrideOrigin (1.70s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsBrowserTTLWithBypass
--- PASS: TestAccCloudflareRuleset_CacheSettingsBrowserTTLWithBypass (9.21s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsInvalidBrowserTTLWithBypass
--- PASS: TestAccCloudflareRuleset_CacheSettingsInvalidBrowserTTLWithBypass (1.88s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsInvalidBrowserTTLWithOverrideOrigin
--- PASS: TestAccCloudflareRuleset_CacheSettingsInvalidBrowserTTLWithOverrideOrigin (1.76s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsDefinedQueryStringExcludeKeys
--- PASS: TestAccCloudflareRuleset_CacheSettingsDefinedQueryStringExcludeKeys (9.84s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsDefinedQueryStringIncludeKeys
--- PASS: TestAccCloudflareRuleset_CacheSettingsDefinedQueryStringIncludeKeys (10.08s)
=== RUN   TestAccCloudflareRuleset_CacheSettingsHandleDefaultHeaderExcludeOrigin
--- PASS: TestAccCloudflareRuleset_CacheSettingsHandleDefaultHeaderExcludeOrigin (23.75s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets	131.566s

@jacobbednarz jacobbednarz merged commit b0ce603 into cloudflare:master Oct 17, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Oct 17, 2023
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants