Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for D1 #2850

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Adds support for D1 #2850

merged 5 commits into from
Oct 16, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Oct 14, 2023

Closes #2544

Adds support for D1 databases

Also, a small docs update clarifying that logging options are only valid for the skip action. There is an API error of logging options only allowed in the skip action (20018) that is returned if you try with other rules. Might be better to add a validator for it but not 100% on how to do so.

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3
Copy link
Contributor Author

$ TF_ACC=1 go test ./internal/framework/service/d1/ -v -count 1 -run ^TestAccCloudflareD1Database_ -timeout 120m -parallel 1
=== RUN   TestAccCloudflareD1Database_Basic
=== PAUSE TestAccCloudflareD1Database_Basic
=== CONT  TestAccCloudflareD1Database_Basic
--- PASS: TestAccCloudflareD1Database_Basic (3.57s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/d1   

@jacobbednarz
Copy link
Member

Also, a small docs update clarifying that logging options are only valid for the skip action. There is an API error of logging options only allowed in the skip action (20018) that is returned if you try with other rules. Might be better to add a validator for it but not 100% on how to do so.

can you please split this into two PRs? I don't like unrelated changes being merged in a single PR.

@Cyb3r-Jak3
Copy link
Contributor Author

Done

.changelog/2850.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

thanking you!

acceptance tests all looking good

TF_ACC=1 go test ./internal/framework/service/d1 -v -run "^TestAccCloudflareD1Database_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareD1Database_Basic
=== PAUSE TestAccCloudflareD1Database_Basic
=== CONT  TestAccCloudflareD1Database_Basic
--- PASS: TestAccCloudflareD1Database_Basic (13.86s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/d1	14.775s

@jacobbednarz jacobbednarz merged commit 5e3368e into cloudflare:master Oct 16, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Oct 16, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the d1 branch October 16, 2023 00:28
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support D1
2 participants