-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for D1 #2850
Adds support for D1 #2850
Conversation
changelog detected ✅ |
$ TF_ACC=1 go test ./internal/framework/service/d1/ -v -count 1 -run ^TestAccCloudflareD1Database_ -timeout 120m -parallel 1
=== RUN TestAccCloudflareD1Database_Basic
=== PAUSE TestAccCloudflareD1Database_Basic
=== CONT TestAccCloudflareD1Database_Basic
--- PASS: TestAccCloudflareD1Database_Basic (3.57s)
PASS
ok github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/d1 |
can you please split this into two PRs? I don't like unrelated changes being merged in a single PR. |
Done |
thanking you! acceptance tests all looking good
|
This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Closes #2544
Adds support for D1 databases
Also, a small docs update clarifying that logging options are only valid for the skip action. There is an API error oflogging options only allowed in the skip action (20018)
that is returned if you try with other rules. Might be better to add a validator for it but not 100% on how to do so.