Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/cloudflare_api_shield_schema: add API Shield Schema resource #2784

Merged
merged 2 commits into from
Oct 17, 2023
Merged

resource/cloudflare_api_shield_schema: add API Shield Schema resource #2784

merged 2 commits into from
Oct 17, 2023

Conversation

djhworld
Copy link
Contributor

Cloudflare-Go has been updated to include support for schemas in API Shield Schema Validation 2.0.

This PR updates the terraform provider to support managing schemas in API Shield

Depends on cloudflare/cloudflare-go#1406

@djhworld djhworld changed the title APISHI-2358 resource/cloudflare_api_shield_schema: add API Shield Schema resource resource/cloudflare_api_shield_schema: add API Shield Schema resource Sep 21, 2023
@github-actions
Copy link
Contributor

changelog detected ✅

@djhworld djhworld force-pushed the dharper/APISHI-2358 branch from 8db11f4 to 0cea99d Compare October 3, 2023 09:14
@djhworld djhworld force-pushed the dharper/APISHI-2358 branch 2 times, most recently from 9d4a9af to b0e31a5 Compare October 16, 2023 16:12
@djhworld djhworld force-pushed the dharper/APISHI-2358 branch from b0e31a5 to 944ce59 Compare October 16, 2023 16:18
@djhworld djhworld marked this pull request as ready for review October 16, 2023 16:26
@jacobbednarz
Copy link
Member

acceptance tests all looking good! 🎖️

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAPIShieldSchema_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAPIShieldSchema_Create
--- PASS: TestAccCloudflareAPIShieldSchema_Create (14.14s)
=== RUN   TestAccCloudflareAPIShieldSchema_CreateForceNew
--- PASS: TestAccCloudflareAPIShieldSchema_CreateForceNew (24.12s)
=== RUN   TestAccCloudflareAPIShieldSchema_Update
--- PASS: TestAccCloudflareAPIShieldSchema_Update (13.64s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	54.047s

@jacobbednarz jacobbednarz merged commit 3c045cb into cloudflare:master Oct 17, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Oct 17, 2023
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
Update CHANGELOG.md for #2784
1923581
@github-actions
Copy link
Contributor

This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhworld @jacobbednarz