Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for authenticated_origin_pulls & authenticated_origin_pulls_certificate #2771

Merged
merged 9 commits into from
Sep 20, 2023

Conversation

Nmishin
Copy link
Contributor

@Nmishin Nmishin commented Sep 17, 2023

Closes #2733

@github-actions
Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member

LGTM. can you please also run make docs locally to generate and commit the documentation artifacts too?

@Nmishin
Copy link
Contributor Author

Nmishin commented Sep 18, 2023

@jacobbednarz in the Authenticated Origin Pull configuration we need to have two // in the end, for make import work:

origin_pulls$ terraform import cloudflare_authenticated_origin_pulls.my_aop df066cb84f969ab8f4bc51b7f2eb2aa6
cloudflare_authenticated_origin_pulls.my_aop: Importing from ID "df066cb84f969ab8f4bc51b7f2eb2aa6"...
╷
│ Error: invalid id ("df066cb84f969ab8f4bc51b7f2eb2aa6") specified, should be in format "zoneID/certID/hostname"
│ 
│ 
╵

origin_pulls$ 
origin_pulls$ terraform import cloudflare_authenticated_origin_pulls.my_aop df066cb84f969ab8f4bc51b7f2eb2aa6//
cloudflare_authenticated_origin_pulls.my_aop: Importing from ID "df066cb84f969ab8f4bc51b7f2eb2aa6//"...
cloudflare_authenticated_origin_pulls.my_aop: Import prepared!
  Prepared cloudflare_authenticated_origin_pulls for import
cloudflare_authenticated_origin_pulls.my_aop: Refreshing state... [id=00b781a09f02ce30521eb094f58228ff]

Import successful!

The resources that were imported are shown above. These resources are now in
your Terraform state and will henceforth be managed by Terraform.

@jacobbednarz
Copy link
Member

that seems to be a bug in the Import then. if we need a way to denote the different types, we can look to update the import string to be something with the right identifiers.

@Nmishin
Copy link
Contributor Author

Nmishin commented Sep 18, 2023

Agree, I will check theImport when I have free time.

@jacobbednarz jacobbednarz merged commit 14fb797 into cloudflare:master Sep 20, 2023
8 checks passed
@jacobbednarz
Copy link
Member

thanks @Nmishin 👏

@github-actions github-actions bot added this to the v4.16.0 milestone Sep 20, 2023
github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
Nmishin pushed a commit to Nmishin/terraform-provider-cloudflare that referenced this pull request Sep 25, 2023
troymjones pushed a commit to troymjones/terraform-provider-cloudflare that referenced this pull request Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

This functionality has been released in v4.16.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants