Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log/slog instead of zerolog #758

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Use log/slog instead of zerolog #758

merged 1 commit into from
Oct 19, 2023

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.46.0-69-ga795ccc
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

internal/log/handler.go Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

Codecov Report

Merging #758 (21c295e) into main (5e16654) will decrease coverage by 0.09%.
Report is 4 commits behind head on main.
The diff coverage is 89.77%.

@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   93.97%   93.88%   -0.09%     
==========================================
  Files          85       87       +2     
  Lines        8278     8425     +147     
==========================================
+ Hits         7779     7910     +131     
- Misses        379      392      +13     
- Partials      120      123       +3     
Files Coverage Δ
cmd/pint/ci.go 87.30% <100.00%> (+0.33%) ⬆️
cmd/pint/lint.go 94.84% <100.00%> (-0.06%) ⬇️
cmd/pint/logger.go 100.00% <100.00%> (+13.04%) ⬆️
cmd/pint/scan.go 95.88% <100.00%> (ø)
internal/checks/alerts_count.go 100.00% <100.00%> (ø)
internal/checks/promql_series.go 97.39% <100.00%> (+0.13%) ⬆️
internal/checks/rule_link.go 100.00% <100.00%> (ø)
internal/config/config.go 98.84% <100.00%> (ø)
internal/config/rule.go 100.00% <100.00%> (ø)
internal/discovery/discovery.go 96.74% <100.00%> (+0.05%) ⬆️
... and 24 more

@prymitive prymitive merged commit a659800 into main Oct 19, 2023
20 checks passed
@prymitive prymitive deleted the slog branch October 19, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants