-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow matching on rule state #1079
Conversation
Benchmark diff:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 94.84% 94.89% +0.04%
==========================================
Files 100 102 +2
Lines 10086 10184 +98
==========================================
+ Hits 9566 9664 +98
Misses 365 365
Partials 155 155 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request was validated by pint.
✔️ No problems found
Stats
Stat | Value |
---|---|
Version | v0.64.0-43-g8c3a9ab |
Number of rules parsed | 4 |
Number of rules checked | 4 |
Number of problems found | 0 |
Number of offline checks | 0 |
Number of online checks | 0 |
Checks duration | 0 |
Problems
No problems reported
2ffe5a2
to
0c5f1b5
Compare
.github/pint/rules/1.yml
Outdated
@@ -3,7 +3,7 @@ groups: | |||
rules: | |||
- alert: Service Is Down | |||
expr: up == 0 | |||
for: 0s | |||
for: 0m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Information reported by pint alerts/for check.
0m
is the default value of for
, consider removing this redundant line.
ℹ️ To see documentation covering this check and instructions on how to resolve it click here.
f8b6ef6
to
c9729a7
Compare
No description provided.