Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alerts/absent config #1047

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix alerts/absent config #1047

merged 1 commit into from
Jul 26, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.62.1-33-gd4bb855
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   38.52m ± 3%   39.12m ± 6%  +1.55% (p=0.035 n=10)
CheckRules-4     8.514 ± 2%    8.527 ± 2%       ~ (p=0.481 n=10)
geomean         572.7m        577.6m       +0.85%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.39Mi ± 0%   27.39Mi ± 0%       ~ (p=0.315 n=10)
CheckRules-4    940.0Mi ± 0%   941.7Mi ± 0%       ~ (p=0.105 n=10)
geomean         160.4Mi        160.6Mi       +0.09%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.6k ± 0%   131.6k ± 0%       ~ (p=0.183 n=10)
CheckRules-4    13.97M ± 0%   13.98M ± 0%       ~ (p=0.075 n=10)
geomean         1.356M        1.356M       +0.03%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (bfeb640) to head (d4bb855).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          97       97           
  Lines        9874     9874           
=======================================
  Hits         9352     9352           
  Misses        366      366           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit f981872 into main Jul 26, 2024
20 checks passed
@prymitive prymitive deleted the alerts/absent branch July 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants