Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor github reporer to use common comments code #1037

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Refactor github reporer to use common comments code #1037

merged 1 commit into from
Jul 23, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.62.1-25-g4bb0c3e
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Jul 18, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   38.97m ± 2%   38.92m ± 2%       ~ (p=1.000 n=10)
CheckRules-4     8.507 ± 2%    8.522 ± 2%       ~ (p=1.000 n=10)
geomean         575.8m        575.9m       +0.01%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.38Mi ± 0%   27.39Mi ± 0%       ~ (p=0.247 n=10)
CheckRules-4    937.2Mi ± 0%   937.1Mi ± 0%       ~ (p=0.853 n=10)
geomean         160.2Mi        160.2Mi       -0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.6k ± 0%   131.6k ± 0%       ~ (p=0.538 n=10)
CheckRules-4    13.93M ± 0%   13.92M ± 0%       ~ (p=0.853 n=10)
geomean         1.354M        1.354M       -0.00%

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 91.03774% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.68%. Comparing base (615fa79) to head (4bb0c3e).

Files Patch % Lines
internal/reporter/github.go 86.81% 7 Missing and 5 partials ⚠️
internal/reporter/gitlab.go 76.47% 4 Missing ⚠️
cmd/pint/ci.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
+ Coverage   94.58%   94.68%   +0.10%     
==========================================
  Files          96       96              
  Lines        9816     9818       +2     
==========================================
+ Hits         9284     9296      +12     
+ Misses        376      366      -10     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive force-pushed the github branch 4 times, most recently from e2f787f to ddd704d Compare July 23, 2024 13:30
@@ -6,7 +6,7 @@ groups:
for: 0s

- alert: Service Is Down
expr: up{job="abc"} == 0
expr: up{job="abc} == 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Bug reported by pint rule/label check.


priority label is required.


ℹ️ To see documentation covering this check and instructions on how to resolve it click here.

@@ -6,7 +6,7 @@ groups:
for: 0s

- alert: Service Is Down
expr: up{job="abc"} == 0
expr: up{job="abc} == 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Fatal reported by pint promql/syntax check.


Prometheus failed to parse the query with this PromQL error: unterminated quoted string.

Click here for PromQL documentation.


ℹ️ To see documentation covering this check and instructions on how to resolve it click here.

@prymitive prymitive force-pushed the github branch 2 times, most recently from 57dca9a to 6600e2b Compare July 23, 2024 14:31
Copy link

This pint run would create 2 comment(s), which is more than the limit configured for pint (1).
1 comment(s) were skipped and won't be visibile on this PR.

@prymitive prymitive merged commit c148213 into main Jul 23, 2024
20 checks passed
@prymitive prymitive deleted the github branch July 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants