support detect and use corresponding manager and fix windows related error #34

Yoinky3000 · 2022-11-27T13:40:53Z

This PR is created to achieve the following things:

Use the package manager that was used in the project to build

yarn v2+ without nodeLinker set to node-modules isn't supported since vercel build pipeline doesn't support Plug'n'Play

fix spawn npm ENOENT error occured when running on windows
normalize path when running on windows (back slash to forward slash) so esbuild can identify the path properly

slash normalization changes:

L544-L547

L557

L571-574

L575-578

Fixes #52

Yoinky3000 · 2022-11-28T12:33:36Z

Seems like support for Route Group cant be achieved by simply add experimentalResponseStreaming detection, so i removed it

LucasLundJensen · 2022-12-16T20:36:50Z

This PR solved my exact issue.
+1 for merging this into main branch.

For reference, I got the following error:

node:events:505
      throw er; // Unhandled 'error' event
      ^

Error: spawn npm ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn npm',
  path: 'npm',
  spawnargs: [ 'install', '-D', 'vercel' ]
}

changeset-bot · 2022-12-20T13:55:06Z

⚠️ No Changeset found

Latest commit: b063e6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

danburonline · 2023-01-16T16:45:37Z

Is this ready to merge?

Cherry

I would recommend you revert the formatting changes. Cloudflare uses tabs in most of its JS/TS projects these days since they're better for accessibility. See cloudflare/workers-sdk#1298 for details.

Adding an .editorconfig and prettier config is a good idea - but I'd grab it from https://github.com/cloudflare/wrangler2 and in another PR.

Yoinky3000 · 2023-01-17T01:01:05Z

I would recommend you revert the formatting changes. Cloudflare uses tabs in most of its JS/TS projects these days since they're better for accessibility. See cloudflare/wrangler2#1298 for details.

Adding an .editorconfig and prettier config is a good idea - but I'd grab it from https://github.com/cloudflare/wrangler2 and in another PR.

I have changed the formatting config, same as the config of wrangler2

hanford · 2023-01-17T22:52:51Z

@LOLBRUHNICE how is this different than the PR I opened?

Yoinky3000 · 2023-01-17T23:06:16Z

@LOLBRUHNICE how is this different than the PR I opened?

First, I noticed that your pr only utilize the package manager when installing vercel, for the building it still use npx, so I created this pr to fully utilize the consumer package manager. Instead of installing vercel, I made it directly use dlx for yarn and pnpm, and use npx for npm(though yarn classic still need to install the vercel first)

Than I noticed that there are also some windows related issue so I also changed some code to solve those problems

Yoinky3000 · 2023-01-17T23:13:46Z

so there are differences between your pr and this pr

nr1brolyfan · 2023-02-01T21:22:57Z

Would love this to be merged, so I could finally use next-on-pages after a month of waiting #52

Pavel-Sushko · 2023-02-07T01:06:20Z

Please merge 🙏🏻

dario-piotrowicz · 2023-03-13T15:29:51Z

Hello @LOLBRUHNICE Thank you so very much for this PR, and sorry it hasn't been reviewed in a while 🙇

I am sorry for being a bother but this PR is quite large and broad in scope so it's quite difficult to tackle, moreover it contains some code that goes against changes we applied recently, like the use of package managers: #71 (or the Windows fix that is being addressed by #86)

(I also did open a PR with prettier since by its title and description I didn't think this PR was setting it up: #90)

If it were not too much trouble it would be fantastic if you could remove everything from this PR that isn't specific for point 3 in your description (or close this PR and open a new one if you prefer) 🙏, so that we can land that quickly (if it is too much trouble let me know, and I can apply the change for you here)

Again I am very sorry for this, we've had issues with finding the time to address PRs and some like this haven't gotten the attention they deserved, we're putting a significant effort to improve this and try to reviews PRs from now on much more swiftly.

Also we hope you will continue contributing to the project, if you do, please try to keep PRs smaller and more focused so that they are easier and quicker to review and merge (and other PRs implementing the same changes don't go against it)

Yoinky3000 · 2023-03-13T22:55:08Z

Hello @LOLBRUHNICE Thank you so very much for this PR, and sorry it hasn't been reviewed in a while 🙇

I am sorry for being a bother but this PR is quite large and broad in scope so it's quite difficult to tackle, moreover it contains some code that goes against changes we applied recently, like the use of package managers: #71 (or the Windows fix that is being addressed by #86)

(I also did open a PR with prettier since by its title and description I didn't think this PR was setting it up: #90)

If it were not too much trouble it would be fantastic if you could remove everything from this PR that isn't specific for point 3 in your description (or close this PR and open a new one if you prefer) 🙏, so that we can land that quickly (if it is too much trouble let me know, and I can apply the change for you here)

Again I am very sorry for this, we've had issues with finding the time to address PRs and some like this haven't gotten the attention they deserved, we're putting a significant effort to improve this and try to reviews PRs from now on much more swiftly.

Also we hope you will continue contributing to the project, if you do, please try to keep PRs smaller and more focused so that they are easier and quicker to review and merge (and other PRs implementing the same changes don't go against it)

ok, I will create a new pr and try to keep the changes as simple as I can

dario-piotrowicz · 2023-03-13T23:01:46Z

@LOLBRUHNICE thank you so very much! sorry about it again 🙇

Yoinky3000 and others added 5 commits November 27, 2022 13:10

add support for Route Group and detect pkg manager

f4c31b9

edit README

3a10c3f

Fix won't get package manager if using --help

20e051d

only allow yarn classic berry with nodeLinker

2ecfb54

remove detecting experimentalResponseStreaming

67f693e

Yoinky3000 changed the title ~~Add support for Route Group and detect package manager~~ Add support for auto detect and use corresponding package manager Nov 28, 2022

sync to the main branch

b59bfe5

Yoinky3000 and others added 7 commits December 20, 2022 21:57

Merge branch 'main' into main

ed428c8

forget to add js-yaml

eecabdf

install types for js-yaml

50ff1b1

only download cli with yarn v1 & fix window \ path

5aa6f68

edit readme

8f0eaa7

use dlx inside buildVercel for yarn v3

07e0eb9

add .editorconfig (from the pr by SnO2WMaN)

8f64aea

Cherry suggested changes Jan 16, 2023

View reviewed changes

use cloudflare project's common formatting config

b0ac699

Yoinky3000 requested a review from Cherry January 17, 2023 02:50

Yoinky3000 changed the title ~~Add support for auto detect and use corresponding package manager~~ support detect and use corresponding manager and fix windows related error Jan 17, 2023

Yoinky3000 mentioned this pull request Jan 17, 2023

Error: spawn npm ENOENT #52

Closed

Merge branch 'main' into main

727e7c1

Yoinky3000 added 2 commits February 13, 2023 17:23

change version

7671b3f

Merge branch 'main' into main

7b5f3ec

Cherry mentioned this pull request Mar 9, 2023

Add eslint and prettier #90

Merged

Merge branch 'main' into main

b063e6f

dario-piotrowicz closed this Mar 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support detect and use corresponding manager and fix windows related error #34

support detect and use corresponding manager and fix windows related error #34

Yoinky3000 commented Nov 27, 2022 •

edited

Loading

Yoinky3000 commented Nov 28, 2022

LucasLundJensen commented Dec 16, 2022

changeset-bot bot commented Dec 20, 2022 •

edited

Loading

danburonline commented Jan 16, 2023

Cherry left a comment •

edited

Loading

Yoinky3000 commented Jan 17, 2023

hanford commented Jan 17, 2023

Yoinky3000 commented Jan 17, 2023 •

edited

Loading

Yoinky3000 commented Jan 17, 2023

nr1brolyfan commented Feb 1, 2023

Pavel-Sushko commented Feb 7, 2023

dario-piotrowicz commented Mar 13, 2023

Yoinky3000 commented Mar 13, 2023

dario-piotrowicz commented Mar 13, 2023

support detect and use corresponding manager and fix windows related error #34

support detect and use corresponding manager and fix windows related error #34

Conversation

Yoinky3000 commented Nov 27, 2022 • edited Loading

Yoinky3000 commented Nov 28, 2022

LucasLundJensen commented Dec 16, 2022

changeset-bot bot commented Dec 20, 2022 • edited Loading

⚠️ No Changeset found

danburonline commented Jan 16, 2023

Cherry left a comment • edited Loading

Choose a reason for hiding this comment

Yoinky3000 commented Jan 17, 2023

hanford commented Jan 17, 2023

Yoinky3000 commented Jan 17, 2023 • edited Loading

Yoinky3000 commented Jan 17, 2023

nr1brolyfan commented Feb 1, 2023

Pavel-Sushko commented Feb 7, 2023

dario-piotrowicz commented Mar 13, 2023

Yoinky3000 commented Mar 13, 2023

dario-piotrowicz commented Mar 13, 2023

Yoinky3000 commented Nov 27, 2022 •

edited

Loading

changeset-bot bot commented Dec 20, 2022 •

edited

Loading

Cherry left a comment •

edited

Loading

Yoinky3000 commented Jan 17, 2023 •

edited

Loading