Skip to content

Merge pull request #405 from cloudflare/dependabot/go_modules/github.… #557

Merge pull request #405 from cloudflare/dependabot/go_modules/github.…

Merge pull request #405 from cloudflare/dependabot/go_modules/github.… #557

Triggered via push September 26, 2023 15:22
Status Success
Total duration 3m 26s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

go.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

10 errors
lint: client/client.go#L391
exported function DefaultLoadPubKey should have comment or be unexported
lint: client/keys.go#L69
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
lint: client/keys.go#L75
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
lint: client/remote.go#L141
exported func GetConnPool returns unexported type *client.connPoolType, which can be annoying to use
lint: cmd/gokeyless/gokeyless.go#L243
error strings should not be capitalized or end with punctuation or a newline
lint: cmd/gokeyless/gokeyless.go#L406
receiver name config should be consistent with previous receiver name c for Config
lint: cmd/gokeyless/gokeyless.go#L427
receiver name config should be consistent with previous receiver name c for Config
lint: internal/test/params/params.go#L25
exported var RSAMD5SHA1Params should have comment or be unexported
lint: internal/test/params/params.go#L49
exported var ECDSASHA224Params should have comment or be unexported
lint: internal/test/params/params.go#L69
exported var ECDSAURI should have comment or be unexported