chore: add passive sampling option to tracing #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikulin
requested changes
Aug 22, 2024
lbarthon
force-pushed
the
lbarthon/tracing-sampler
branch
from
70fabc0
to
f997fe8
Compare
lbarthon
force-pushed
the
lbarthon/tracing-sampler
branch
from
f997fe8
to
58f59ad
Compare
inikulin
reviewed
Aug 24, 2024
When we have many services in the same flow, we want to defer the sampling logic to the parent service (which will defer to the root service in the end). The PassiveSampler is really good for that, as it will only sample traces that have one external reference. This assumes that the parent service will send the trace info to stitch, if we should keep it, and won't, if we should discard it. This is what some of our services do already today, and it would really help us onboard to foundations! This also fixes the previous rate limiting test, that would always return an empty traces list, as they were sent to a non-existent scope.
lbarthon
force-pushed
the
lbarthon/tracing-sampler
branch
from
58f59ad
to
80a678b
Compare
inikulin
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have many services in the same flow, we want to defer the sampling logic to the parent service (which will defer to the root service in the end).
The PassiveSampler is really good for that, as it will only sample traces that have one external reference. This assumes that the parent service will send the trace info to stitch, if we should keep it, and won't, if we should discard it. This is what some of our services do already today, and it would really help us onboard to foundations!
This needs cloudflare/rustracing#2 merged &
cf-rustracingbumped in order to compile and work fine.