Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.4.0 #48

Closed
wants to merge 1 commit into from
Closed

Release 3.4.0 #48

wants to merge 1 commit into from

Conversation

bcottrell8738
Copy link
Contributor

My motivation for proposing a release is that I would like to get #47

I was figuring a "minor" bump for that, but I'm open to different viewpoints.

@nmldiegues
Copy link
Collaborator

Clippy isn't happy

Copy link
Collaborator

@fisherdarling fisherdarling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run cargo-semver-checks to determine the level of breaking changes? Since we don't track manually what's breaking or not, it's hard to tell from the RELEASE_NOTES.

@bcottrell8738
Copy link
Contributor Author

Can we run cargo-semver-checks to determine the level of breaking changes? Since we don't track manually what's breaking or not, it's hard to tell from the RELEASE_NOTES.

cargo semver-checks says it needs to be a major version (!) -- I don't know if that also means we want more coordination around the timing of this. I was just hoping to get my change in there, but maybe my change should take a back seat.

@fisherdarling
Copy link
Collaborator

Can we run cargo-semver-checks to determine the level of breaking changes? Since we don't track manually what's breaking or not, it's hard to tell from the RELEASE_NOTES.

cargo semver-checks says it needs to be a major version (!) -- I don't know if that also means we want more coordination around the timing of this. I was just hoping to get my change in there, but maybe my change should take a back seat.

Like it's suggesting 4.0.0? That's fine! Whatever the semver gods require.

@bcottrell8738 bcottrell8738 closed this by deleting the head repository Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants