fix: validate api input

cloudflare · Aug 9, 2023 · ac9be65 · ac9be65
1 parent 18eaf59
commit ac9be65
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/boringtun/src/device/api.rs b/boringtun/src/device/api.rs
@@ -210,7 +210,12 @@ fn api_set(reader: &mut BufReader<&UnixStream>, d: &mut LockReadGuard<Device>) -
             let mut cmd = String::new();
 
             while reader.read_line(&mut cmd).is_ok() {
-                cmd.pop(); // remove newline if any
+                let end = cmd.pop(); // remove newline if any
+                if let Some(end) = end {
+                    if end != '\n' {
+                        return EPROTO;
+                    }
+                }
                 if cmd.is_empty() {
                     return 0; // Done
                 }