Adding hmac.h to included headers #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmittler
force-pushed
the
hmac
branch
2 times, most recently
from
94a5ac8
to
fef3036
Compare
|
FYI @PiotrSikora |
|
@inikulin would you mind taking a look? I suspect this should be non-controversial |
PiotrSikora
approved these changes
Jul 31, 2023
This was originally going to be fixed by cloudflare#101, however that PR was closed and superseded by cloudflare#117, which was missing this fix. The original problem was caused by cloudflare#97, which updated boringssl to a version that included [a change that removed hmac.h from ssl.h](google/boringssl@05b360d). This PR adds an include for hmac.h, so it is again available through boring-sys.
|
FYI @nox as well |
nox
approved these changes
Aug 1, 2023
|
Thanks @nox! And sorry for the spam, I thought you were a maintainer. Do you happen to know any maintainers that might help get this merged? |
|
I am a maintainer, actually 😅 |
|
Ha! Oh perfect ... CI seemed to still be stuck waiting for approval, so I assumed your approval wasn't sufficient. Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally going to be fixed by #101, however that PR was closed and superseded by #117, which was missing this fix.
The original problem was caused by #97, which updated boringssl to a version that included a change that removed hmac.h from ssl.h.
This PR adds an include for hmac.h, so it is again available through boring-sys.