Update link to Message definition in spec #937
Conversation
|
Hello Sir :) Do you mind going through the repo and fix the other occasions as well? Would be awesome. Quick grep I did (please verify) grep -lir master .
./test/sql/shortcircuit_test.go
./docs/concepts.md
./binding/format/protobuf/v2/pb/cloudevent.pb.go
./binding/format/protobuf/v2/pb/cloudevent.proto
./.gitmodules
./README.md
./v2/binding/encoding.go
./v2/event/eventcontext_v03.go
./sql/v2/parser/case_changing_stream.go
./sql/v2/README.md
./sql/v2/CESQLLexer.g4 |
hasheddan
force-pushed
the
fix/spec-link
branch
from
128040c
to
9c61606
Compare
|
@embano1 a number of the refs from your grep are versioned links that are not broken so I opted not to update those -- however, this PR does now fix all broken links. |
| @@ -7,7 +7,7 @@ | |||
| package pb | |||
|
|
|||
| import ( | |||
| any "github.com/golang/protobuf/ptypes/any" | |||
| any1 "github.com/golang/protobuf/ptypes/any" | |||
There was a problem hiding this comment.
did you make those changes intentionally?
There was a problem hiding this comment.
these were automatically made as part of generation -- I installed the matching versions of protoc and protoc-gen-go as detailed at the top of this file. I would imagine these changes were made automatically because I have a newer version of go installed locally (go1.20.7) and the any alias conflicts with the any keyword. I'm happy to generate with 1.17 if preferred, though it might be desirable to go ahead and update these.
There was a problem hiding this comment.
Yeah, we're still including 1.17 to make sure older versions of Go can use the SDK/we don't accidentally start using >go1.17 features (until we decide to bump).
IMHO the any1 is not a breaking change here, but if you don't mind please re-gen with 1.17 so we don't introduce this change?
There was a problem hiding this comment.
IMHO the any1 is not a breaking change here, but if you don't mind please re-gen with 1.17 so we don't introduce this change?
Sounds good, will do!
There was a problem hiding this comment.
whoops definitely not!
Fixes broken links to cloudevents spec. Signed-off-by: Daniel Mangum <[email protected]>
hasheddan
force-pushed
the
fix/spec-link
branch
from
9c61606
to
1bcaa28
Compare
Fixes broken links to cloudevents spec.
Signed-off-by: Daniel Mangum [email protected]