Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #928 - change denpendency sarama from Shopify to IBM #930

Merged

Conversation

astronaut1712
Copy link
Contributor

@astronaut1712 astronaut1712 commented Aug 7, 2023

Change dependency from "github.com/Shopify/sarama" is changed to "github.com/IBM/sarama".

@astronaut1712 astronaut1712 force-pushed the 928-change-dependency-sarama branch 3 times, most recently from 54857d9 to 71a3742 Compare August 7, 2023 04:09
@astronaut1712 astronaut1712 changed the title issue 928 - change denpendency sarama from Shopify to IBM issue #928 - change denpendency sarama from Shopify to IBM Aug 7, 2023
@embano1
Copy link
Member

embano1 commented Aug 7, 2023

@astronaut1712 thx! Please the see failing tests for how to resolve.

@astronaut1712
Copy link
Contributor Author

@astronaut1712 thx! Please the see failing tests for how to resolve.

I have updated the test/integration and test/comformance

@embano1 embano1 enabled auto-merge August 7, 2023 08:38
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@embano1 embano1 merged commit 7f5ef39 into cloudevents:main Aug 7, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants