Add WithHost Option #1070
Merged
Add WithHost Option #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxtonw
force-pushed
the
1069-set-host-header
branch
2 times, most recently
from
1517c03
to
39444c5
Compare
Signed-off-by: Jaxton Winder <[email protected]> Improve error message for nil protocol Signed-off-by: Jaxton Winder <[email protected]> Add unit test for WithHost Signed-off-by: Jaxton Winder <[email protected]>
embano1
approved these changes
Jul 4, 2024
|
Thank you! |
|
@embano1 happy to help! Roughly when can we expect the next release that this change will be included in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggested solution #2 from Issue #1069.
Adds a new
WithHostoption for HTTP Protocols to enable the ability to set the HTTPHostheader manually.