Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-storagebrowser] moves the new storage browser to new endpoint #3978

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal commented Jan 30, 2025

What changes were proposed in this pull request?

  • The New Storage Browser is now moved to a new frontend url, this eliminates the various issues caused in old file browser.

  • When enable_new_sotrage_browser flag is enabled, user will see only the new file browser in the sidebar but can access the old file browser via old url

  • When enable_new_sotrage_browser flag is disabled, user will see only old file browser in the sidebar but can access the new file browser via new url

How was this patch tested?

  • Manually tested

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal changed the title [ui-importer] fixes the importer when new file browser is enabled [filebrowser] fixes the importer when new file browser is enabled Jan 30, 2025
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 30, 2025 13:38
@ramprasadagarwal ramprasadagarwal changed the title [filebrowser] fixes the importer when new file browser is enabled [storagebrowser] fix filechooser modal in importer for new storagebrowser Jan 30, 2025
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 30, 2025 13:40
@tabraiz12
Copy link
Collaborator

can you explain a little more what is the exact issue this fixes? i.e what is the current issue

@ramprasadagarwal ramprasadagarwal marked this pull request as draft January 30, 2025 15:03
auto-merge was automatically disabled January 30, 2025 15:03

Pull request was converted to draft

@ramprasadagarwal ramprasadagarwal marked this pull request as ready for review January 30, 2025 20:12
@ramprasadagarwal ramprasadagarwal changed the title [storagebrowser] fix filechooser modal in importer for new storagebrowser [ui-storagebrowser] moves the new storage browser to new endpoint Jan 30, 2025
@tabraiz12
Copy link
Collaborator

@ramprasadagarwal Let there be only one storage browser icon in the left side bar at one time. Both url should should work

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 31, 2025 07:25
@tabraiz12
Copy link
Collaborator

Thanks for making the change. LGTM.

@ramprasadagarwal ramprasadagarwal merged commit 4a863dc into master Jan 31, 2025
5 of 6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-23 branch January 31, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants