[security] Fix AJAX Loading of Inline Scripts in editFile #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desktop/core/src/desktop/static/desktop/js/file-display-inline.js
Outdated
Show resolved
Hide resolved
ramprasadagarwal
approved these changes
Jan 29, 2025
bjornalm
approved these changes
Jan 30, 2025
Better yet, perhaps CI can detect additions of new unsafe-inline js/css? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue: Inline scripts from AJAX responses aren't executed due to CSP restrictions when unsafe-inline is removed.
Fix: Manually process and append scripts from AJAX responses to ensure execution.
How was this patch tested?
tested in local
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Hue Contributing Guide before opening a pull request.