Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trino] Enhance the logic to efficiently retrieve the rows #3972

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[Trino] Enhance the logic to efficiently retrieve the rows #3972

merged 1 commit into from
Jan 31, 2025

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Jan 27, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • Enhance the logic to efficiently retrieve the 100 rows for every fetch_result call

How was this patch tested?

  • Locally and E2E
  • Unittest

@agl29 agl29 force-pushed the trino_fetch_result branch 2 times, most recently from c24dc87 to 8742b5d Compare January 31, 2025 09:14
@agl29 agl29 force-pushed the trino_fetch_result branch 2 times, most recently from f24bebd to 758168e Compare January 31, 2025 10:51
Harshg999
Harshg999 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JohanAhlen
JohanAhlen approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

desktop/libs/notebook/src/notebook/connectors/trino.py Outdated Show resolved Hide resolved
@agl29 agl29 force-pushed the trino_fetch_result branch from 758168e to 6bee35f Compare January 31, 2025 13:32
@agl29 agl29 enabled auto-merge (squash) January 31, 2025 13:33
@agl29 agl29 merged commit 887bba5 into master Jan 31, 2025
5 of 6 checks passed
@agl29 agl29 deleted the trino_fetch_result branch January 31, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@Harshg999 Harshg999 Harshg999 approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agl29 @JohanAhlen @Harshg999