Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-core] move hooks to nested folder #3969

Merged
merged 3 commits into from
Jan 27, 2025
Merged

[ui-core] move hooks to nested folder #3969

merged 3 commits into from
Jan 27, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • the current hooks folder is getting bigger as the number of hooks increases, this PR moves each hook along with its test and util file to its own folder.

How was this patch tested?

  • Updated unit tests

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Jan 24, 2025
bjornalm
bjornalm approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 27, 2025 14:40
@ramprasadagarwal ramprasadagarwal merged commit 07ab5d5 into master Jan 27, 2025
6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-19 branch January 27, 2025 14:50
tabraiz12 pushed a commit that referenced this pull request Jan 31, 2025
@ramprasadagarwal
[ui-core] move hooks to nested folder (#3969)
7b0a52f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabraiz12 tabraiz12 tabraiz12 approved these changes

@bjornalm bjornalm bjornalm approved these changes

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadagarwal @tabraiz12 @bjornalm