Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Job browser fix #3963

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Mini Job browser fix #3963

merged 2 commits into from
Jan 22, 2025

Conversation

tabraiz12
Copy link
Collaborator

What changes were proposed in this pull request?

the variables used was rawHtml instead of $rawHtml. As Html was not getting embedded it was having issues.

How was this patch tested?

  • Manually tested to verify that mini job browser is working

Please review Hue Contributing Guide before opening a pull request.

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabraiz12 tabraiz12 enabled auto-merge (squash) January 22, 2025 17:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@tabraiz12 tabraiz12 merged commit 1673b1f into master Jan 22, 2025
5 of 6 checks passed
@tabraiz12 tabraiz12 deleted the mini-job-browser branch January 22, 2025 17:22
tabraiz12 added a commit that referenced this pull request Jan 27, 2025
Co-authored-by: Mohammed Tabraiz <[email protected]>
(cherry picked from commit 1673b1f)
(cherry picked from commit b2ff5761f8c2284fe061a73b3279551997bde75c)
amitsrivastava pushed a commit that referenced this pull request Mar 10, 2025
Co-authored-by: Mohammed Tabraiz <[email protected]>
(cherry picked from commit 1673b1f)
(cherry picked from commit b2ff5761f8c2284fe061a73b3279551997bde75c)
athithyaaselvam pushed a commit that referenced this pull request Mar 11, 2025
Co-authored-by: Mohammed Tabraiz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants