Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Move pytest and its dependencies from make apps to make test_prep #3948

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

wing2fly
Copy link
Collaborator

…t_prep`

What changes were proposed in this pull request?

Separate test required package in different build target

How was this patch tested?

Manual

Please review Hue Contributing Guide before opening a pull request.

@agl29 agl29 changed the title [test] Move pytest and its dependencies from make apps to `make tes… [test] Move pytest and its dependencies from make apps to make test_prep Jan 10, 2025
Copy link
Contributor

@ranade1 ranade1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wing2fly wing2fly force-pushed the test_prep branch 3 times, most recently from abbf8ea to 8abebc8 Compare February 5, 2025 00:17
@@ -108,6 +108,13 @@ all: default
# <<<< DEV ONLY
include Makefile.tarball

###################################
# Build docs (unused)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change comment telling more about the command?

@@ -96,7 +96,7 @@ default:
@echo ' clean : Remove desktop build products'
@echo ' distclean : Remove desktop and thirdparty build products'
# <<<< DEV ONLY
@echo ' doc : Build documentation'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add info about the new command also?

@wing2fly wing2fly merged commit 3817ea8 into master Feb 6, 2025
5 of 6 checks passed
@wing2fly wing2fly deleted the test_prep branch February 6, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants